Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5327
to review the following change.
Change subject: flume sink: Fix jar shading
......................................................................
flume sink: Fix jar shading
Previously, when generating the kudu-flume-sink jar, we pulled in many
unshaded dependencies. This change improves the situation considerably
by doing the following:
1. Make the hadoop jars provided. This is find because Flume always puts
the Hadoop jars for the version it is running against on its
classpath.
2. Use the transitive shading provided by the kudu-client jar. This
makes it so that the kudu-client dependencies don't pollute the
classpath. Previously, unshaded kudu-client dependencies were being
included (which was surprising).
After this change the only non-org.apache.kudu classes in the classpath
are inherited from kudu-client, and once we fix KUDU-1780 then that will
be resolved as well.
Change-Id: I0ac2b67636c9f13f56cec2ea526d42c9e11f6b78
---
M java/kudu-flume-sink/pom.xml
1 file changed, 7 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/5327/1
--
To view, visit http://gerrit.cloudera.org:8080/5327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ac2b67636c9f13f56cec2ea526d42c9e11f6b78
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
