Mike Percy has posted comments on this change. Change subject: flume sink: Fix jar shading ......................................................................
Patch Set 2: > Could a test check for the expected shading? Would a test like that > fit into the current infrastructure? That's a good idea, and I think we should do it, but as a follow-up patch. You could run a script that does something like "jar tf foo.jar" and then greps for anything not starting with org/apache/kudu and throws an error if it finds something not in a whitelist. It could be triggered as part of build-support/jenkins/build-and-test.sh -- To view, visit http://gerrit.cloudera.org:8080/5327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac2b67636c9f13f56cec2ea526d42c9e11f6b78 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: No
