Dan Burkert has posted comments on this change. Change subject: flume sink: Fix jar shading ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5327/1/java/kudu-flume-sink/pom.xml File java/kudu-flume-sink/pom.xml: Line 29: <build> While you are modifying this, could you move this <build> block below the dependencies? That's how all our other poms have it. Line 38: <!-- We want to transitively shade what kudu-client shades. --> I don't think this comment is right - this shades the kudu client classes, kudu-flume shouldn't need to know or worry that internally kudu-client uses shaded classes. Line 39: <include>org.apache.kudu:kudu-client</include> I think this can be simplified to <include>*:*</include> that's what kudu-spark does, so it's probably best to be consistent (unless there's something I'm missing and that won't work for this case). -- To view, visit http://gerrit.cloudera.org:8080/5327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac2b67636c9f13f56cec2ea526d42c9e11f6b78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
