Will Berkeley has posted comments on this change.

Change subject: flume sink: Fix jar shading
......................................................................


Patch Set 2: Code-Review+2

LGTM provisional on build passing.

Could a test check for the expected shading? Would a test like that fit into 
the current infrastructure?

-- 
To view, visit http://gerrit.cloudera.org:8080/5327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac2b67636c9f13f56cec2ea526d42c9e11f6b78
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: No

Reply via email to