Dan Burkert has posted comments on this change. Change subject: block manager: start using the file cache ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/5147/9/src/kudu/fs/block_manager.cc File src/kudu/fs/block_manager.cc: Line 64: env->IncreaseOpenFileLimit(); I think there is a case for calling this regardless of the max_open_files configuration. Line 74: "Configured file descriptor limit $0 exceeds process fd limit $1", I think this message will be more actionable as Configured open file limit (block_manager_max_open_files) $0 exceeds process fd limit (ulimit) $1 -- To view, visit http://gerrit.cloudera.org:8080/5147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeefd31eca340111bc535eac1f982290e7703a88 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
