Adar Dembo has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5403/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 346: max_num_blocks_(block_manager->block_limits_by_data_dir_[data_dir]), > can you use FindOrDie here? Yeah, I forgot FindOrDie() returns the value (thought it passed it as an OUT param. Line 1828: return major <= 2 && minor <= 6 && patch <= 32 && extra < 674; > is this right? seems like it would count '1.7.0.0' as newer. Oh, I would loved to know about autodigit comparisons. Using C regexps was not fun at all. And I still got it wrong. Sigh. -- To view, visit http://gerrit.cloudera.org:8080/5403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63576d2bf2cc61b2deb70f7e166f08e0d4c66543 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
