Dan Burkert has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: Line 1247: TEST_F(LogBlockManagerTest, TestContainerWithManyHoles) { > This test fails on macOS: https://gist.github.com/6c13d83a0032a9168a37bb1be BTW - this disabling this test on OS X is a valid way forward, but that divide by 0 should probably be checked. -- To view, visit http://gerrit.cloudera.org:8080/5403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63576d2bf2cc61b2deb70f7e166f08e0d4c66543 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
