Adar Dembo has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: Line 1247: TEST_F(LogBlockManagerTest, TestContainerWithManyHoles) { > BTW - this disabling this test on OS X is a valid way forward, but that div Ugh. I forgot to add RETURN_NOT_LOG_BLOCK_MANAGER() here and in the other test. I'm not worried too much about the error; there's a RETURN_NOT_LOG_BLOCK_MANAGER() in SetUp() so this test is manipulating an instantiated but not Open()ed log block manager. Line 1342: TEST_F(LogBlockManagerTest, TestContainerBlockLimiting) { > Same here. Done http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/util/env.h File src/kudu/util/env.h: Line 41: typedef std::unordered_map<std::string, Mount> MountMap; > this can be removed now Done Line 573: struct Mount { > can be removed, right? Done http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 20: #include <sys/vfs.h> > This isn't found on macOS. Moving it into the non-mac block makes everythi Done -- To view, visit http://gerrit.cloudera.org:8080/5403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63576d2bf2cc61b2deb70f7e166f08e0d4c66543 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
