Dan Burkert has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: Line 1341: Could you add a test that fills out a container to the block limit, and then restarts with a higher limit, and continues writing? This is to simulate a user upgrading from a buggy kernel to a non-buggy kernel, and ensuring that the previously limited containers can be written to. http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 67: "bug with hole punching on ext4."); Might help to include the JIRA #. http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: Line 290: static const std::map<int, int> per_fs_block_size_block_limits; please use a fixed-size int type. -- To view, visit http://gerrit.cloudera.org:8080/5403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63576d2bf2cc61b2deb70f7e166f08e0d4c66543 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
