Adar Dembo has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5403/6/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 328: int64_t total_blocks_written_ = 0; > Here and for the flag the # of blocks is int64_t, but for the limits you ha I opted for int32_t in the KUDU-1508 limits because I knew those (fixed) values would be very small, but I understand that the inconsistency is a little jarring. I'll change it back to int64_t. -- To view, visit http://gerrit.cloudera.org:8080/5403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63576d2bf2cc61b2deb70f7e166f08e0d4c66543 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
