Todd Lipcon has posted comments on this change.

Change subject: KUDU-1806. java: fetching scan tokens should fetch larger 
batches
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5498/2//COMMIT_MSG
Commit Message:

PS2, Line 9: This changes the number of tablets fetched in a single 
GetTableLocations
           : RPC from 10 to 1000.
> Unless there's a good reason not to, I'd like to see a similar change made 
will separate that into a different change


PS2, Line 16: it turns out that point
            : lookups already set an 'endPartitionKey' parameter in the RPC
> I was previously under the impression that we never set the endPartitionKey
oh shoot, you're right. We enter loopLocateTable() with the endPartitionKey set 
but don't forward it to the master. Back to the original approach.


-- 
To view, visit http://gerrit.cloudera.org:8080/5498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46260a96dfd0847f70146496e48c2766b8e17ea9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to