Todd Lipcon has posted comments on this change.

Change subject: KUDU-1806. java: fetching scan tokens should fetch larger 
batches
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5498/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

Line 737:         locateTablet(request.getTable(), partitionKey, 
FETCH_TABLETS_PER_POINT_LOOKUP, request);
> This being the generic sendRpcToTablet() method, how do we know that we're 
Maybe the commit message wasn't clear enough. Scans (i.e not scan token 
generation) are still "point lookups" from the tablet location cache 
perspective. Scan token generation (where you explicitly lookup a range) get 
the new treatment.


-- 
To view, visit http://gerrit.cloudera.org:8080/5498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46260a96dfd0847f70146496e48c2766b8e17ea9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to