Todd Lipcon has posted comments on this change. Change subject: KUDU-1806. java: fetching scan tokens should fetch larger batches ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5498/2//COMMIT_MSG Commit Message: PS2, Line 16: it turns out that point : lookups already set an 'endPartitionKey' parameter in the RPC > oh shoot, you're right. We enter loopLocateTable() with the endPartitionKey OK, new patch goes back to the original approach. I will do some spot checks with YCSB to make sure that this workload is still requesting 10 tablets at a time while the scan token generation fetches 1000. It's somewhat hard to automate that test, but should be easy to verify using the /tracing.html stuff -- To view, visit http://gerrit.cloudera.org:8080/5498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46260a96dfd0847f70146496e48c2766b8e17ea9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
