Matthew Jacobs has posted comments on this change.

Change subject: Update Impala docs for upcoming Impala 2.8 release
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5733/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

Line 30: Kudu has tight integration with Apache Impala, allowing you to use 
Impala
(incubating) necessary?


PS1, Line 365: // TODO(todd) Composite partition keys for range partitioning 
are not allowed
             : // anymore in Impala 2.8?
Except when specifying '=', i.e. no n-dimensional ranges

... (PARTITION VALUE = (1, 'Martin'))


PS1, Line 703: regardless of whether the table is an internal or external
             : table. This avoids disruption to other applications that may be 
accessing the
             : underlying Kudu table.
this isn't true, internal tables will be renamed. I was surprised by this as 
well but IIWII at this point.


PS1, Line 707: .Rename the underlying Kudu table for an internal table
             : 
             : If a table is an internal table, the underlying Kudu table may 
be renamed by
             : changing the `kudu.table_name` property:
I think we wanna talk about this for external tables, given what I said above


-- 
To view, visit http://gerrit.cloudera.org:8080/5733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43d18e8d92c52e5868e1d48b91351bca41b53f8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Ambreen Kazi <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: John Russell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-HasComments: Yes

Reply via email to