Matthew Jacobs has posted comments on this change.

Change subject: Update Impala docs for upcoming Impala 2.8 release
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5733/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

PS1, Line 39: Impala 2.8 
> question: I just noticed that the build I'm testing (CDH 5.10 pre-release) 
I think unfortunately the version in the code will still say 2.7, but we're 
talking about 2.8. I guess this will be like a known issue. I'll double check.


PS1, Line 703: regardless of whether the table is an internal or external
             : table. This avoids disruption to other applications that may be 
accessing the
             : underlying Kudu table.
> It's true in the version I'm testing with: https://gist.github.com/a2c5e6a8
My bad


PS1, Line 707: .Rename the underlying Kudu table for an internal table
             : 
             : If a table is an internal table, the underlying Kudu table may 
be renamed by
             : changing the `kudu.table_name` property:
> I think we wanna talk about this for external tables, given what I said abo
ignore; this is too complicated I can't even keep it straight I have to try it 
every time :/


-- 
To view, visit http://gerrit.cloudera.org:8080/5733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43d18e8d92c52e5868e1d48b91351bca41b53f8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Ambreen Kazi <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: John Russell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to