Todd Lipcon has posted comments on this change.

Change subject: Update Impala docs for upcoming Impala 2.8 release
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5733/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

PS1, Line 39: Impala 2.8 
> I think unfortunately the version in the code will still say 2.7, but we're
ugh... yea I just checked on a CDH 5.10 cluster and it still says 5.7. I 
changed up this section to match.


http://gerrit.cloudera.org:8080/#/c/5733/2/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

PS2, Line 144: same names and types as the columns in `old_table`
> technically its the names and types of the columns in the select stmt; you 
Done


PS2, Line 158: Tables are divided into tablets which are each served by one or 
more tablet
             : servers. Ideally, tablets should split a table's data relatively 
equally. Kudu currently
             : has no mechanism for automatically (or manually) splitting a 
pre-existing tablet.
             : Until this feature has been implemented, *you must specify your 
partitioning when
             : creating a table*. When designing your table schema, consider 
primary keys that will allow you to
             : split your table into partitions which grow at similar rates. 
You can designate
             : partitions using a `PARTITION BY` clause when creating a table 
using Impala:
             : 
             : NOTE: Impala keywords, such as `group`, are enclosed by 
back-tick characters when
             : they are not used in their keyword sense.
> This text has been duplicated in the Partitioning Tables section below.
Done


PS2, Line 370: `DISTRIBUTE
             : BY HASH (id, sku)`.
> old syntax - DISTRIBUTE BY
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43d18e8d92c52e5868e1d48b91351bca41b53f8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Ambreen Kazi <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: John Russell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to