Todd Lipcon has posted comments on this change.

Change subject: Update Impala docs for upcoming Impala 2.8 release
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5733/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

Line 30: Kudu has tight integration with Apache Impala, allowing you to use 
Impala
> (incubating) necessary?
typically it's OK to use "incubating" only in the first reference in a 
document, iirc, and it's referenced as incubating in the title. But I'll add it 
here just in case


PS1, Line 39: Impala 2.8 
question: I just noticed that the build I'm testing (CDH 5.10 pre-release) says:
impalad version 2.7.0-cdh5.10.0 RELEASE (build 
1c57740759e175d8810c6790af3c5a60862a0ce9

even though it seems to correspond more or less to upstream 2.8. Should I 
instead be documenting this in a different way? Or will the final bits say 2.8?


PS1, Line 365: // TODO(todd) Composite partition keys for range partitioning 
are not allowed
             : // anymore in Impala 2.8?
> Except when specifying '=', i.e. no n-dimensional ranges
ok, I'm just going to delete this section for now, and assume that this 
document doesn't need to be fully comprehensive.


PS1, Line 703: regardless of whether the table is an internal or external
             : table. This avoids disruption to other applications that may be 
accessing the
             : underlying Kudu table.
> this isn't true, internal tables will be renamed. I was surprised by this a
It's true in the version I'm testing with: 
https://gist.github.com/a2c5e6a869459a7121f2e71b29c86677
impalad version 2.7.0-cdh5.10.0 RELEASE (build 
1c57740759e175d8810c6790af3c5a60862a0ce9


-- 
To view, visit http://gerrit.cloudera.org:8080/5733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43d18e8d92c52e5868e1d48b91351bca41b53f8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Ambreen Kazi <ambreen.k...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: John Russell <jruss...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to