Adar Dembo has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag ......................................................................
Patch Set 2: (2 comments) OK, let's move forward with the new gflag then. Still two small things to address. http://gerrit.cloudera.org:8080/#/c/5741/2//COMMIT_MSG Commit Message: PS2, Line 9: In the case of a CHECK() failure, both the crashing thread and the : AsyncLogger thread may simultaneously attempt to symbolize their stacks. : AsyncLogger does this simply by acquiring a Mutex in RunThread(), which : triggers stack collection in DEBUG mode, while the crashing thread is : collecting the stack trace in order to print an important error message. > Useful information, but the way it's written it sounds like AsyncLogger::R Could you address this? http://gerrit.cloudera.org:8080/#/c/5741/7/src/kudu/util/mutex.cc File src/kudu/util/mutex.cc: Line 73: << "; Owner stack: " << std::endl << stack_trace_->Symbolize(); Could we at least drop the (empty) stack part of the line? Maybe if the value of the new gflag is false, we could mention that if you want stacks, you need to enable so-and-so flag? In Acquire() too. -- To view, visit http://gerrit.cloudera.org:8080/5741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4593cf7173867ce2f6151e03df0be94f97d95d2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
