Mike Percy has posted comments on this change.

Change subject: Control mutex stack walking in DEBUG mode with a gflag
......................................................................


Patch Set 10:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5741/10//COMMIT_MSG
Commit Message:

PS10, Line 19: excluvisity
> Nit: exclusivity
Done


http://gerrit.cloudera.org:8080/#/c/5741/10/src/kudu/util/mutex.cc
File src/kudu/util/mutex.cc:

Line 100:   DCHECK_EQ(0, rv) << ". " << strerror(rv) << ". " << 
GetOwnerThreadInfo();
> I think moving the DCHECK_EQ() into the NDEBUG check has the effect of caus
Ugh, yeah. Fixed.


-- 
To view, visit http://gerrit.cloudera.org:8080/5741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4593cf7173867ce2f6151e03df0be94f97d95d2
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to