Todd Lipcon has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag ......................................................................
Patch Set 5: I don't think this is harmful, and in fact maybe it would help improve performance on debug builds enough that losing the stack trace collection is not a big deal. I rarely use the mutex stacks, and usually when I do it's already in the context where I could reproduce an issue with the flag enabled. That said for the particular issue here, I do think it sounds like a glog bug that they aren't using a TLS flag if their only goal is to prevent reentrancy. I'd be OK committing this if we also file an upstream glog bug suggesting that the global is inappropriate here and that TLS would be better. -- To view, visit http://gerrit.cloudera.org:8080/5741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4593cf7173867ce2f6151e03df0be94f97d95d2 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
