Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5741/2//COMMIT_MSG Commit Message: PS2, Line 9: In the case of a CHECK() failure, both the crashing thread and the : AsyncLogger thread may simultaneously attempt to symbolize their stacks. : AsyncLogger does this simply by acquiring a Mutex in RunThread(), which : triggers stack collection in DEBUG mode, while the crashing thread is : collecting the stack trace in order to print an important error message. > Could you address this? Done http://gerrit.cloudera.org:8080/#/c/5741/7/src/kudu/util/mutex.cc File src/kudu/util/mutex.cc: Line 73: << "; Owner stack: " << std::endl << stack_trace_->Symbolize(); > Could we at least drop the (empty) stack part of the line? Maybe if the val Done -- To view, visit http://gerrit.cloudera.org:8080/5741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4593cf7173867ce2f6151e03df0be94f97d95d2 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
