Alexey Serbin has posted comments on this change. Change subject: Fix some clang-tidy errors for std::move ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5867/1/src/kudu/client/master_rpc.cc File src/kudu/client/master_rpc.cc: PS1, Line 89: Sockaddr addr if getting rid of moving POD objects (that's great, btw), would it make sense to have it as 'const Sockaddr&' parameter instead? At least, on OS X sockaddr_in is significantly more than 64 bits. -- To view, visit http://gerrit.cloudera.org:8080/5867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a51478685a50c50c84319bd32d506fe372c3c4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
