Todd Lipcon has submitted this change and it was merged. Change subject: Fix some clang-tidy errors for std::move ......................................................................
Fix some clang-tidy errors for std::move Clang-tidy reported a few errors in a recent code review of moved code[1]. Rather than fix them in the commit that just moved the code, I fixed them separately. This also fixes a few other similar cases I spotted where shared_ptr<Messenger> should be std::moved, and other cases where MonoTime/MonoDelta should not be std::moved. [1] https://gerrit.cloudera.org/#/c/5864/1/src/kudu/client/master_rpc.cc Change-Id: I61a51478685a50c50c84319bd32d506fe372c3c4 Reviewed-on: http://gerrit.cloudera.org:8080/5867 Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Todd Lipcon <[email protected]> --- M src/kudu/client/batcher.cc M src/kudu/client/client-internal.cc M src/kudu/client/master_rpc.cc M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/rpc/exactly_once_rpc-test.cc M src/kudu/rpc/proxy.cc M src/kudu/rpc/proxy.h M src/kudu/rpc/reactor.cc M src/kudu/rpc/reactor.h M src/kudu/rpc/retriable_rpc.h M src/kudu/rpc/rpc-bench.cc M src/kudu/rpc/rpc.h M src/kudu/tools/ksck.cc M src/kudu/tools/ksck_remote.h 15 files changed, 46 insertions(+), 46 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Todd Lipcon: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61a51478685a50c50c84319bd32d506fe372c3c4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
