Todd Lipcon has posted comments on this change. Change subject: Fix some clang-tidy errors for std::move ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5867/1/src/kudu/client/master_rpc.cc File src/kudu/client/master_rpc.cc: PS1, Line 89: Sockaddr addr > if getting rid of moving POD objects (that's great, btw), would it make sen Done http://gerrit.cloudera.org:8080/#/c/5867/1/src/kudu/rpc/exactly_once_rpc-test.cc File src/kudu/rpc/exactly_once_rpc-test.cc: Line 174: int server_sleep = 0) : latch_(1) { > warning: parameter 'server_sleep' is unused [misc-unused-parameters] this seems like it might be a legit bug. I'll email David about it. http://gerrit.cloudera.org:8080/#/c/5867/1/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: PS1, Line 495: : messenger_(std::move(messenger)), : name_(StringPrintf("%s_R%03d", messenger_->name().c_str(), index)), : closing_(false), : thread_(this, bld) { > Nit: realign these? Done -- To view, visit http://gerrit.cloudera.org:8080/5867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a51478685a50c50c84319bd32d506fe372c3c4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
