Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5867
to review the following change.
Change subject: Fix some clang-tidy errors for std::move
......................................................................
Fix some clang-tidy errors for std::move
Clang-tidy reported a few errors in a recent code review
of moved code[1]. Rather than fix them in the commit that just moved the
code, I fixed them separately. This also fixes a few other similar cases
I spotted where shared_ptr<Messenger> should be std::moved, and other
cases where MonoTime/MonoDelta should not be std::moved.
[1] https://gerrit.cloudera.org/#/c/5864/1/src/kudu/client/master_rpc.cc
Change-Id: I61a51478685a50c50c84319bd32d506fe372c3c4
---
M src/kudu/client/batcher.cc
M src/kudu/client/client-internal.cc
M src/kudu/client/master_rpc.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/proxy.cc
M src/kudu/rpc/proxy.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
M src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc-bench.cc
M src/kudu/rpc/rpc.h
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck_remote.h
15 files changed, 41 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/5867/1
--
To view, visit http://gerrit.cloudera.org:8080/5867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61a51478685a50c50c84319bd32d506fe372c3c4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
