Hello Dan Burkert, Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5927
to review the following change.
Change subject: Make SecureRpcHelper a Netty pipeline stage
......................................................................
Make SecureRpcHelper a Netty pipeline stage
This decouples SecureRpcHelper from TabletClient. When negotiation is
complete, it sends an "event" upstream to the TabletClient and removes
itself from the pipeline.
I'm hoping this decoupling will make it easier to test SecureRpcHelper
in isolation as we add more functionality like TLS negotiation.
After this is committed, I'm also hoping to rename SecureRpcHelper to
Negotiator.
Change-Id: I5f4b4516219b8eebf24786b4ceb13f2e6260f03b
---
M java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java
2 files changed, 85 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/5927/1
--
To view, visit http://gerrit.cloudera.org:8080/5927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f4b4516219b8eebf24786b4ceb13f2e6260f03b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
