Todd Lipcon has posted comments on this change. Change subject: Make SecureRpcHelper a Netty pipeline stage ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5927/1/java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java: Line 113: > RED yea, I need to figure out how to configure eclipse not to do this. Line 127: RpcHeader.NegotiatePB response = parseSaslMsgResponse(buf); > This needs to check for an error response, or maybe punt and add a TODO. added a TODO -- To view, visit http://gerrit.cloudera.org:8080/5927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f4b4516219b8eebf24786b4ceb13f2e6260f03b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
