Todd Lipcon has submitted this change and it was merged. Change subject: Make SecureRpcHelper a Netty pipeline stage ......................................................................
Make SecureRpcHelper a Netty pipeline stage This decouples SecureRpcHelper from TabletClient. When negotiation is complete, it sends an "event" upstream to the TabletClient and removes itself from the pipeline. I'm hoping this decoupling will make it easier to test SecureRpcHelper in isolation as we add more functionality like TLS negotiation. After this is committed, I'm also hoping to rename SecureRpcHelper to Negotiator. Change-Id: I5f4b4516219b8eebf24786b4ceb13f2e6260f03b Reviewed-on: http://gerrit.cloudera.org:8080/5927 Reviewed-by: Dan Burkert <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans <[email protected]> --- M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java M java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java M java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java 4 files changed, 116 insertions(+), 83 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f4b4516219b8eebf24786b4ceb13f2e6260f03b Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
