Jean-Daniel Cryans has posted comments on this change. Change subject: WIP: fixes for java client kerberos against a real cluster ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5922/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 1830: private static Subject getSubjectOrLogin() { Seems like this could be extracted into some helper class. Line 1840: @Override Pretty sure we normally use double indentation for anonymous classes. PS2, Line 1874: c Could* http://gerrit.cloudera.org:8080/#/c/5922/2/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java: Line 85: public InetAddress getResolvedAddress() { nit: javadoc -- To view, visit http://gerrit.cloudera.org:8080/5922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b96fad3cfb40500d7a75e5070ea21bc8e00cbd8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
