Todd Lipcon has posted comments on this change.

Change subject: java: fix ability to connect to a real Kerberized cluster
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5922/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java
File java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java:

PS3, Line 210:  
> nit
Done


Line 216:     // For each of our own mechanisms, in descending priority, check 
if
> Why is it not sufficient to check whether the client subject has kerberos c
I found an issue where I had kinitted to an entirely different Kerberos realm, 
and thus I had kerberos credentials, but not to the actual realm matching the 
server. So, createSaslClient() fails with an error for GSSAPI and then falls 
back to PLAIN.


Line 245:     
> nit
Done


http://gerrit.cloudera.org:8080/#/c/5922/3/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java:

PS3, Line 86: .
> remove
Done


http://gerrit.cloudera.org:8080/#/c/5922/3/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java:

PS3, Line 328: .
> remove
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b96fad3cfb40500d7a75e5070ea21bc8e00cbd8
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to