Todd Lipcon has posted comments on this change. Change subject: WIP: fixes for java client kerberos against a real cluster ......................................................................
Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/5922/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 1830: private static Subject getSubjectOrLogin() { > Seems like this could be extracted into some helper class. Done PS2, Line 1834: " > use {} substitution Done Line 1840: @Override > Pretty sure we normally use double indentation for anonymous classes. Done Line 1850: options.put("debug", "" + Boolean.getBoolean("kudu.jaas.debug")); > Boolean.toString(Boolean.getBoolean("kudu.jaas.debug")) Done Line 1871: LOG.debug("Logged in as subject: " + subject.toString()); > {} substitution Done PS2, Line 1874: c > Could* Done http://gerrit.cloudera.org:8080/#/c/5922/2/java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java: Line 116: if (saslClient == null || !saslClient.isComplete() || negoUnderway) { > Looks like this could this be simplified to just 'if (negoUnderway)' Done Line 206: for (RpcHeader.NegotiatePB.SaslAuth auth : response.getAuthsList()) { > This shouldn't be done in a loop. The Java client should intersect the ser Done Line 270: if (e instanceof SaslException) { > This would be simpler as a separate catch clause. it complains about that because the Subject.doAs doesn't say it "throws SaslException". I used Throwables from guava here which is cleaner. http://gerrit.cloudera.org:8080/#/c/5922/2/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java: Line 85: public InetAddress getResolvedAddress() { > nit: javadoc Done -- To view, visit http://gerrit.cloudera.org:8080/5922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b96fad3cfb40500d7a75e5070ea21bc8e00cbd8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
