Dan Burkert has posted comments on this change. Change subject: WIP: fixes for java client kerberos against a real cluster ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5922/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: PS2, Line 1834: " use {} substitution Line 1850: options.put("debug", "" + Boolean.getBoolean("kudu.jaas.debug")); Boolean.toString(Boolean.getBoolean("kudu.jaas.debug")) Line 1871: LOG.debug("Logged in as subject: " + subject.toString()); {} substitution http://gerrit.cloudera.org:8080/#/c/5922/2/java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java: Line 116: if (saslClient == null || !saslClient.isComplete() || negoUnderway) { Looks like this could this be simplified to just 'if (negoUnderway)' Line 206: for (RpcHeader.NegotiatePB.SaslAuth auth : response.getAuthsList()) { This shouldn't be done in a loop. The Java client should intersect the server-supported mechs with it's own, and then preferentially pick from that set (GSSAPI over PLAIN). See C++ client. https://github.com/apache/kudu/blob/master/src/kudu/rpc/client_negotiation.cc#L329-L377 Line 270: if (e instanceof SaslException) { This would be simpler as a separate catch clause. } catch (RuntimeException|SaslException e) { throw e; } catch (Exception e) { throw new RuntimeException(e); } -- To view, visit http://gerrit.cloudera.org:8080/5922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b96fad3cfb40500d7a75e5070ea21bc8e00cbd8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
