Todd Lipcon has posted comments on this change. Change subject: [security] load/store public TSK in the system table ......................................................................
Patch Set 23: (1 comment) Agreed that addressing the shutdown deadlock should be done separately from this patch (I based a bunch of patches on top of this one and none of them hit the deadlock, so I dont think it's overly common anyway) http://gerrit.cloudera.org:8080/#/c/5935/23/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 3293: leader_lock_.AssertAcquiredForReading(); > Yes, we discussed it, but I think we came to two different conclusions. :) That's fair, I'm also fine with dropping it and relying on TSAN to check for us. -- To view, visit http://gerrit.cloudera.org:8080/5935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie91d4129bda0ca49e81988c28385895a2abcd201 Gerrit-PatchSet: 23 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
