Dan Burkert has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog ......................................................................
Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/5930/14/src/kudu/security/token_signer.cc File src/kudu/security/token_signer.cc: Line 97: RETURN_NOT_OK(verifier_->ImportKeys({ public_key_pb })); > I don't think it's worth adding a method just for this case. Batching keys Ok, then how about changing ImportKeys to ImportKey and taking just one key at a time? Line 168: // It does not make much sense to keep more than two keys in the queue. > Try to think of that the following way: Ok I think I was missing the critical 2 keys in the queue piece. Let's go with it as is. Line 176: return Status::OK(); > Interesting. To me it's much easier to look at that in the absolute time s The current R17 version looks great to me. http://gerrit.cloudera.org:8080/#/c/5930/17/src/kudu/security/token_signer.cc File src/kudu/security/token_signer.cc: PS17, Line 48: n Capitalize -- To view, visit http://gerrit.cloudera.org:8080/5930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2417e2ccba6a1114db366b2f642f95362bf479c Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
