Alexey Serbin has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog ......................................................................
Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/5930/14/src/kudu/security/token_signer.cc File src/kudu/security/token_signer.cc: Line 97: RETURN_NOT_OK(verifier_->ImportKeys({ public_key_pb })); > Ok, then how about changing ImportKeys to ImportKey and taking just one key After some consideration I found it's not that hard to accumulate public parts of the keys and then import them in a batch manner. Line 168: const auto* key = tsk_deque_.front().get(); > Ok I think I was missing the critical 2 keys in the queue piece. Let's go sgtm Line 176: if (key->expire_time() - key_validity_seconds_ + key_rotation_seconds_ <= > The current R17 version looks great to me. All right, then let's keep that R17 version. http://gerrit.cloudera.org:8080/#/c/5930/17/src/kudu/security/token_signer.cc File src/kudu/security/token_signer.cc: PS17, Line 48: n > Capitalize Done -- To view, visit http://gerrit.cloudera.org:8080/5930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2417e2ccba6a1114db366b2f642f95362bf479c Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
