Todd Lipcon has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog ......................................................................
Patch Set 14: > Todd and I just discussed this offline. Looks like the best route is to make > a virtual method getters for the TokenVerifier on ServerBase, and then master > can implement those through the TokenSigner, and tserver can implement them > through a new TokenVerifier field. The existing TokenVerifier field on > ServerBase can be removed. I'm looking at this a bit more trying to hook up everything together. I don't think the virtual method thing works as is, because ServerBase doesn't have the TokenVerifier, Messenger does. As much as shared ownership is often a kludge, I think a shared_ptr<TokenVerifier> shared by the signer and the messenger is the way to go. I'll try that at least as a quick solution. -- To view, visit http://gerrit.cloudera.org:8080/5930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2417e2ccba6a1114db366b2f642f95362bf479c Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
