Alexey Serbin has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6117/2/src/kudu/security/token-test.cc File src/kudu/security/token-test.cc: Line 164: static const int64_t kKeyRotationIntervalSeconds = 2; > given we run our tests distributed, I'm not against just making this have a 2 seconds is more than enough here, actually. What is the complexity that you see in using 2 seconds instead of 10? That additional timing measurement? PS2, Line 183: GTEST_LOG_ > what's this? why not normal LOG()? It's a nice printing stuff form GTEST, but I suspect the trailing underscore hints that's for internal use. GTEST_LOG_(WARNING): [WARNING] /home/aserbin/Projects/kudu/src/kudu/security/token-test.cc:191:: timings are too tight for this run, skipping the rest of the test scenario LOG(WARNING): W0222 18:28:15.045966 16100 token-test.cc:191] timings are too tight for this run, skipping the rest of the test scenario The latter is in color in colorful terminal. We can use LOG() here, sure. -- To view, visit http://gerrit.cloudera.org:8080/6117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3112b389f22bb60f424eb2fbce4e1068f2ec84bd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
