Todd Lipcon has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6117/2/src/kudu/security/token-test.cc File src/kudu/security/token-test.cc: Line 164: static const int64_t kKeyRotationIntervalSeconds = 2; given we run our tests distributed, I'm not against just making this have a wide leeway - maybe make it 10 seconds or something? We have lots of tests that run for 60+ seconds so this won't increase wall clock time of a test run, and we can make it disable itself if (!AllowSlowTests())? Would that make it simpler? PS2, Line 183: GTEST_LOG_ what's this? why not normal LOG()? -- To view, visit http://gerrit.cloudera.org:8080/6117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3112b389f22bb60f424eb2fbce4e1068f2ec84bd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
