Todd Lipcon has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6117/2/src/kudu/security/token-test.cc File src/kudu/security/token-test.cc: Line 164: static const int64_t kKeyRotationIntervalSeconds = 2; > 2 seconds is more than enough here, actually. yea, figured we could get rid of the long block comment above and the long block comment below, and then there would be less cognitive overhead to understand this test. -- To view, visit http://gerrit.cloudera.org:8080/6117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3112b389f22bb60f424eb2fbce4e1068f2ec84bd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
