Alexey Serbin has posted comments on this change. Change subject: [token-test] fixed TestTokenSignerAddKeys flakiness ......................................................................
Patch Set 3: -Verified > I'm not a fan of setting it to 10 seconds. It's not an issue for > distributed tests, but this really hurts when running tests > sequentially (like must be done on OS X). Yep, I also think having those long intervals for wait is not good. However, that long part now engages only when KUDU_ALLOW_SLOW_TESTS is set. And btw, for me on OS X ctest -j4 works fine so far :) Let's converge then -- I would return that piece of extra-logic here, but it seems Todd does not like that approach. What would be the best way of resolving this? Any thoughts? -- To view, visit http://gerrit.cloudera.org:8080/6117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3112b389f22bb60f424eb2fbce4e1068f2ec84bd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
