Alexey Serbin has posted comments on this change. Change subject: KUDU-1927 [master] always send IPKI CA certificate ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6356/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: Line 396: if (!l.CheckIsInitializedOrRespond(resp, rpc)) { > What if we replaced this with CheckIsInitializedAndIsLeaderOrRespond()? Cou I think it might be a good idea. However, using that check in this context would mean client always get an error if trying to call this method against master in FOLLOWER role. Is that what we want? I'm not sure. Line 416: return; > IIUC, the response is (status: ServiceUnavailable, role: LEADER, code: NOT_ As I understand, the role field in the response would be set to UNKNOWN_ROLE. -- To view, visit http://gerrit.cloudera.org:8080/6356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a20e6da6531091fcc597af58a7bbf01a8847f5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
