Alexey Serbin has posted comments on this change. Change subject: KUDU-1927 [master] always send IPKI CA certificate ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6356/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: PS1, Line 410: const Status s(Status::ServiceUnavailable( : "not yet ready to serve the request as the leader master")); > How about we adjust the condition slightly then? It could be "if leader_sta Yep, I think we can do that. But what if leader_status_ is something else but ServiceUnavailable (e.g., IllegalState?) What should we do in that case? Or we have some sort of guarantee that would never happen? If so, should I add CHECK() for that? Line 416: return; > My bad, you are right. After some consideration I think we better set it to UNKNOWN_ROLE explicitly, so it would look less suspicious. I think if it looked suspicious to you, then more people could think there is a bug here. -- To view, visit http://gerrit.cloudera.org:8080/6356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a20e6da6531091fcc597af58a7bbf01a8847f5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
