Adar Dembo has posted comments on this change. Change subject: KUDU-1927 [master] always send IPKI CA certificate ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6356/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: PS1, Line 410: const Status s(Status::ServiceUnavailable( : "not yet ready to serve the request as the leader master")); > Yep, I think we can do that. leader_status_.IsIllegalState() means that the master isn't a LEADER, so we should respond with FOLLOWER or something. I don't know if it's safe to believe in Role(); it's possible that this master became a leader in the Raft state machine _just_ after the ScopedLeaderSharedLock constructor ran. Really I'm not sure why we need to access Role() at all; the leader_status() of the lock should be sufficient to tell us whether the master is a leader or not. It's a shame that we're locked into this API that actually exposes the raw Raft role; a boolean is_leader would have been preferable, I think. -- To view, visit http://gerrit.cloudera.org:8080/6356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a20e6da6531091fcc597af58a7bbf01a8847f5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
