Adar Dembo has posted comments on this change. Change subject: KUDU-1927 [master] always send IPKI CA certificate ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6356/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: Line 396: if (!l.CheckIsInitializedOrRespond(resp, rpc)) { > I think it might be a good idea. However, using that check in this context Hmm, maybe not. I'm not sure either. PS1, Line 410: const Status s(Status::ServiceUnavailable( : "not yet ready to serve the request as the leader master")); > I think we want to have the response to be explicit ServiceUnavailable, rig How about we adjust the condition slightly then? It could be "if leader_status().IsServiceUnavailable()", right? That should be enough to indicate that this master is the leader, but is still starting up, and then we could return leader_status() safely. FWIW, the string in the ServiceUnavailable case contains the exact same information: "Leader not yet ready to serve requests". Line 416: return; > As I understand, the role field in the response would be set to UNKNOWN_ROL My bad, you are right. -- To view, visit http://gerrit.cloudera.org:8080/6356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a20e6da6531091fcc597af58a7bbf01a8847f5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
