Mike Percy has posted comments on this change. Change subject: Reduce arguments in file Read API ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env.h File src/kudu/util/env.h: PS3, Line 355: virtual Status Read(Slice* result) > I think the primary motivation for this refactor was the new ReadV() API th Ah, I didn't know we actually deleted the memory mapping code. I just thought we switched away from it in the block manager implementation. If this makes ReadV() easier to implement, I guess it makes sense. -- To view, visit http://gerrit.cloudera.org:8080/6770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e4df425a7387c28eb428e851a9f8c25167755d4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
