Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: Line 183: Status Read<RandomAccessFile>(RandomAccessFile* file, uint64_t offset, Slice* result) { > Done Do we still need the templated Read() though? Can't we just call reader->Read(...) on L219 in ValidateAndReadData()? -- To view, visit http://gerrit.cloudera.org:8080/6770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e4df425a7387c28eb428e851a9f8c25167755d4 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
