Adar Dembo has posted comments on this change. Change subject: Reduce arguments in file Read API ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env.h File src/kudu/util/env.h: Line 382: // possible to read exactly 'length' bytes, an IOError is returned. > It's it on all the "bottom" level reads that any other read wraps. Do you t I was thinking of SequentialFile, but then I remembered that its implementation is different (it uses fread_unlocked) so it probably doesn't make sense. Nevermind. http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 278: req, offset)); > I think I agree. But the offset is being edited in the loop too. I would ne Ah, missed that. Yeah, let's keep the original offset around and incorporate it here. It's cheap. -- To view, visit http://gerrit.cloudera.org:8080/6770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e4df425a7387c28eb428e851a9f8c25167755d4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
