Grant Henke has posted comments on this change. Change subject: Reduce arguments in file Read API ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6770/3/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: Line 183: Status NonShortRead(T* file, uint64_t offset, Slice* result); > Do we still need the templated Read() though? Can't we just call reader->Re I am not strong on c++ templates. However, I think we need to provide some specialized "ReadableFileType" implementation for RandomAccessFile and RWFile since they don't share a common interface for the Read() method. The API just happens to be the same. -- To view, visit http://gerrit.cloudera.org:8080/6770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e4df425a7387c28eb428e851a9f8c25167755d4 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
