Adar Dembo has posted comments on this change.

Change subject: [java-client] Update protoc and simplify the maven build
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6846/1/java/kudu-client/pom.xml
File java/kudu-client/pom.xml:

Line 144
To remove this, I think you need to add attachProtoSources=false to the 
protobuf-maven-plugin configuration. Please test by extracting the kudu-client 
JAR and looking for .proto files inside (there should be none).


Line 138:                     
<protocArtifact>com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}</protocArtifact>
If you don't mind please try this out on SLES 12 SP1, Red Hat or CentOS 6.6, 
Ubuntu 14.04, and Debian 8. You don't actually need to run through the Java 
build (unless you want to); IIUC there will be one executable for any x86_64 
Linux, so just find it and try to run it on those platforms. If it fails to run 
because of a missing glibc symbol version, we've got problems.


-- 
To view, visit http://gerrit.cloudera.org:8080/6846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70f7ad260777d5355497fa7e9a1047c342ff9ee9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to