Grant Henke has posted comments on this change. Change subject: [java-client] Update protoc and simplify the maven build ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6846/1/java/kudu-client/pom.xml File java/kudu-client/pom.xml: Line 144 > To remove this, I think you need to add attachProtoSources=false to the pro I think this step was just trying to remove the test proto's due to some unusual behavior. See "<include>**/*test*.proto</include>". I tested and no test proto is included after my change. Both before and after this change 25 kudu proto files are included in the final jar. I also verified with a jar in maven central. Line 138: <protocArtifact>com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}</protocArtifact> > If you don't mind please try this out on SLES 12 SP1, Red Hat or CentOS 6.6 Will test and report back. http://gerrit.cloudera.org:8080/#/c/6846/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java: Line 30: import com.google.protobuf.UnsafeByteOperations; > duplicate Done -- To view, visit http://gerrit.cloudera.org:8080/6846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f7ad260777d5355497fa7e9a1047c342ff9ee9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
